Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-101100: Fix sphinx warnings in whatsnew/3.0.rst #127662

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

koyuki7w
Copy link
Contributor

@koyuki7w koyuki7w commented Dec 6, 2024

Fixed warnings, mainly append ! to the removed items in version 3.0.


📚 Documentation preview 📚: https://cpython-previews--127662.org.readthedocs.build/

Fixed warnings, mainly append `!` to the removed items in version 3.0.
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, here's a couple of suggestions.

@@ -1,3 +1,5 @@
.. module:: xmlrpc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add this under the header line and with a :synopsis: like in other library files?

Doc/whatsnew/3.0.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.0.rst Outdated Show resolved Hide resolved
@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Dec 9, 2024
@koyuki7w koyuki7w requested a review from hugovk December 10, 2024 02:25
@hugovk
Copy link
Member

hugovk commented Dec 10, 2024

Thanks!

@hugovk hugovk merged commit 8dbdbad into python:main Dec 10, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @koyuki7w for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 10, 2024

GH-127783 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 10, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 10, 2024

GH-127784 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 10, 2024
@koyuki7w koyuki7w deleted the doc-fix-1 branch December 10, 2024 10:24
hugovk added a commit that referenced this pull request Dec 10, 2024
… (#127783)

Co-authored-by: Yuki Kobayashi <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Dec 10, 2024
… (#127784)

Co-authored-by: Yuki Kobayashi <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants