Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-108202: calendar: Document TextCalendar methods #127608

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

gh-108202: calendar: Document TextCalendar methods #127608

wants to merge 9 commits into from
+38 −7

Conversation

StanFromIreland
Copy link
Contributor

@StanFromIreland StanFromIreland commented Dec 4, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Dec 4, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 4, 2024
Open
@StanFromIreland StanFromIreland marked this pull request as ready for review December 5, 2024 16:27
@StanFromIreland

This comment was marked as outdated.

Sign in to view
ZeroIntensity
ZeroIntensity reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments. (I'll tag Erlend again once I consider this ready from a triage standpoint.)

It's probably worth converting the phrase "string representation" into a reference to the str class.

Doc/library/calendar.rst Outdated Show resolved Hide resolved
Doc/library/calendar.rst Outdated Show resolved Hide resolved
Doc/library/calendar.rst Outdated Show resolved Hide resolved
Doc/library/calendar.rst Outdated Show resolved Hide resolved
Doc/library/calendar.rst Outdated Show resolved Hide resolved
@ZeroIntensity ZeroIntensity added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Dec 10, 2024
StanFromIreland and others added 5 commits December 10, 2024 16:04
@StanFromIreland @ZeroIntensity
Update Doc/library/calendar.rst
e3a14b0 
Co-authored-by: Peter Bierma <[email protected]>
@StanFromIreland @ZeroIntensity
Update Doc/library/calendar.rst
a41d652 
Co-authored-by: Peter Bierma <[email protected]>
@StanFromIreland @ZeroIntensity
Update Doc/library/calendar.rst
238befb 
Co-authored-by: Peter Bierma <[email protected]>
@StanFromIreland @ZeroIntensity
Update Doc/library/calendar.rst
781876c 
Co-authored-by: Peter Bierma <[email protected]>
@StanFromIreland
Change string to :class:str
60b524f 
As per ZeroIntenisities suggestion
@Antony3293 Antony3293 mentioned this pull request Dec 10, 2024
Closed
ZeroIntensity
ZeroIntensity reviewed Dec 11, 2024
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll refrain from nitpicking. I don't know enough about calendar to give this a green check, so I'll just tag Erlend.

eendebakpt
eendebakpt reviewed Dec 17, 2024
View reviewed changes
Doc/library/calendar.rst Outdated Show resolved Hide resolved
Doc/library/calendar.rst Outdated Show resolved Hide resolved
Doc/library/calendar.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@eendebakpt eendebakpt eendebakpt left review comments

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip news
Projects
Docs PRs
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StanFromIreland @eendebakpt @ZeroIntensity