-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix param type in PyObject_HasAttrWithError (docs) #127403
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bedevere-app
bot
added
docs
Documentation in the Doc dir
skip news
awaiting review
labels
Nov 29, 2024
kumaraditya303
added
needs backport to 3.12
bug and security fixes
needs backport to 3.13
bugs and security fixes
skip issue
labels
Nov 29, 2024
kumaraditya303
approved these changes
Nov 29, 2024
Thanks @biggus-developerus for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 29, 2024
(cherry picked from commit 3afb639) Co-authored-by: biggus-developerus <[email protected]>
Sorry, @biggus-developerus and @kumaraditya303, I could not cleanly backport this to
|
GH-127404 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Nov 29, 2024
…#127404) fix param type in PyObject_HasAttrWithError (docs) (GH-127403) (cherry picked from commit 3afb639) Co-authored-by: biggus-developerus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Documentation in the Doc dir
needs backport to 3.12
bug and security fixes
skip issue
skip news
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix param type in PyObject_HasAttrWithError (docs)
I was reading through the docs and found out that the
attr_name
parameter in the functionPyObject_HasAttrWithError
was mixed up withPyObject_HasAttrStringWithError
📚 Documentation preview 📚: https://cpython-previews--127403.org.readthedocs.build/