Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix param type in PyObject_HasAttrWithError (docs) #127403

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

biggus-developerus
Copy link
Contributor

@biggus-developerus biggus-developerus commented Nov 29, 2024

fix param type in PyObject_HasAttrWithError (docs)

I was reading through the docs and found out that the attr_name parameter in the function PyObject_HasAttrWithError was mixed up with PyObject_HasAttrStringWithError


📚 Documentation preview 📚: https://cpython-previews--127403.org.readthedocs.build/

Copy link

cpython-cla-bot bot commented Nov 29, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 29, 2024
@kumaraditya303 kumaraditya303 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip issue labels Nov 29, 2024
@kumaraditya303 kumaraditya303 merged commit 3afb639 into python:main Nov 29, 2024
24 of 25 checks passed
@miss-islington-app
Copy link

Thanks @biggus-developerus for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 29, 2024
(cherry picked from commit 3afb639)

Co-authored-by: biggus-developerus <[email protected]>
@miss-islington-app
Copy link

Sorry, @biggus-developerus and @kumaraditya303, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3afb639f39e89888194d8e74cc498c8da3a58d8e 3.12

@bedevere-app
Copy link

bedevere-app bot commented Nov 29, 2024

GH-127404 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 29, 2024
kumaraditya303 pushed a commit that referenced this pull request Nov 29, 2024
…#127404)

fix param type in PyObject_HasAttrWithError (docs) (GH-127403)
(cherry picked from commit 3afb639)

Co-authored-by: biggus-developerus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir needs backport to 3.12 bug and security fixes skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants