Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro expansions in critical section docs #127226

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

da-woods
Copy link
Contributor

@da-woods da-woods commented Nov 24, 2024

These don't match the real code.

See

# define Py_BEGIN_CRITICAL_SECTION2(a, b) \
{ \
PyCriticalSection2 _py_cs2; \
PyCriticalSection2_Begin(&_py_cs2, _PyObject_CAST(a), _PyObject_CAST(b))
# define Py_END_CRITICAL_SECTION2() \
PyCriticalSection2_End(&_py_cs2); \
}
for the current implementation.


📚 Documentation preview 📚: https://cpython-previews--127226.org.readthedocs.build/

These don't match the real code.
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Nov 24, 2024
@da-woods
Copy link
Contributor Author

I'm assuming that this is a small enough typo fix not to need an issue. But I'm happy to create one if needed.

Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@colesbury colesbury merged commit 2bb7846 into python:main Nov 24, 2024
48 checks passed
@miss-islington-app
Copy link

Thanks @da-woods for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 24, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 24, 2024

GH-127229 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 24, 2024
@da-woods da-woods deleted the da-woods-patch-1 branch November 24, 2024 17:21
colesbury pushed a commit that referenced this pull request Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants