gh-126255: Ignore warning about JIT being deactivated when perf support is active in test_embed.InitConfigTests.test_initconfig_api
#126302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in test_initconfig_api This is a temporary measure to get JIT tests passing again. This should be reverted once a more comprehensive fix lands.
|
@Fidget-Spinner - Is there a way I can trigger the JIT tests on this? |
Unfortunately there's no way to trigger the JIT tests. The only way to do this - add change to JIT-related files (for example a newline) |
|
It seems that we still need a couple of changes from #126166 to solve this |
Co-authored-by: Ken Jin <[email protected]> Co-authored-by: Pablo Galindo <[email protected]>
|
I'm pushing this forward because I want to see JIT CI green 🙂 |
Eclips4
reviewed
Nov 1, 2024
Lib/test/test_embed.py
Outdated
| @@ -1780,8 +1781,13 @@ def test_initconfig_api(self): | |||
| 'perf_profiling': 2, | |||
| } | |||
| config_dev_mode(preconfig, config) | |||
| using_jit = any(x.startswith("JIT") for x in get_build_info()) | |||
There was a problem hiding this comment.
Unfortunately this won't work for --enable-experimental-jit=interpreter since it doesn't raise a warning about perf profiling support (because there's no conflict with tier 2 and perf profiler)
There was a problem hiding this comment.
...and get_build_info probably does not work on Windows
Eclips4
force-pushed
the
gh-126255-temp-workaround-embed-test-failure
branch
from
f122803
to
79c966c
Compare
brandtbucher
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary measure to get JIT tests passing again while other folks work on a more comprehensive solution.
test_embed.InitConfigTests.test_initconfig_apifails when cpython is built with--enable-experimental-jit=interpreter#126255