-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-126167: Modify iOS Testbed to read arguments from Info.plist #126169
Conversation
!buildbot iOS |
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit f6ad3c0 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look reasonable. However, I wasn't able to fully test them yet due to #126925.
@ned-deily Yeah - I've seen that, and I'm working on a fix that will both address that problem, fix the "don't get test results until the suite finishes" limitation, provide a useful utility for third parties to test their own code, and simplify the makefile target for CPython's iOS build. That PR builds on this one, though; would you prefer me to merge that work into this PR, or would it be OK to merge this one as-is (on the basis CI verifies that it works as-is for Xcode 15.4)? |
I think either is fine, your call. |
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…pythonGH-126169) Modify iOS Testbed to read arguments from Info.plist. (cherry picked from commit 500a471) Co-authored-by: Russell Keith-Magee <[email protected]>
GH-126940 is a backport of this pull request to the 3.13 branch. |
Ok - I'll merge this one; I'm currently working on the other improvements. PyCon AU is later this week, which might slow my progress a little, so a PR might not be ready until late next week. |
….plist (pythonGH-126169) (python#126940) pythongh-126167: Modify iOS Testbed to read arguments from Info.plist (pythonGH-126169)
…o.plist (pythonGH-126169) (python#126940) pythongh-126167: Modify iOS Testbed to read arguments from Info.plist (pythonGH-126169)
…o.plist (pythonGH-126169) (python#126940) pythongh-126167: Modify iOS Testbed to read arguments from Info.plist (pythonGH-126169)
…o.plist (pythonGH-126169) (python#126940) pythongh-126167: Modify iOS Testbed to read arguments from Info.plist (pythonGH-126169)
…python#126169) Modify iOS Testbed to read arguments from Info.plist.
…o.plist (pythonGH-126169) (python#126940) pythongh-126167: Modify iOS Testbed to read arguments from Info.plist (pythonGH-126169)
…python#126169) Modify iOS Testbed to read arguments from Info.plist.
Modifies the iOS testbed so that:
app
is added toPYTHONPATH
to contain Python code.app_packages
is added toPYTHONPATH
to contain third-party modules (essentially a site-packages that isn't part of the Python framework)app
andapp_packages
folders are processed by the script that converts libraries into frameworksapp
folder.NO_COLOR
is set in the environment to prevent ANSI terminal codes from being emitted. This is required because the Xcode terminal output doesn't support color, and some test systems default to coloured output.This doesn't alter how the testbed is started or used for CPython's test suite - the
app
andapp_packages
folders are empty by default, and aren't used by CPython.However, a third party project can copy this project, add a Python.framework, add test code to
app
, install wheels intoapp_packages
, rewrite theTestArgs
key iniOSTestbed-Info.plist
, and run the Xcode project to evaluate the test suite.Fixes #126167.