Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-118596: Add thread-safety clarifications to the SSLContext documentation (GH-118597) #120595

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 16, 2024

Add thread-safety clarifications to the SSLContext documentation. Per the issue:

This issue has also come up here where the matter was clarified by @tiran in this comment:

SSLContext is designed to be shared and used for multiple connections. It is thread safe as long as you don't reconfigure it once it is used by a connection. Adding new certs to the internal trust store is fine, but changing ciphers, verification settings, or mTLS certs can lead to surprising behavior. The problem is unrelated to threads and can even occur in a single-threaded program.
(cherry picked from commit 4f59f86)

Co-authored-by: mm-matthias [email protected]


📚 Documentation preview 📚: https://cpython-previews--120595.org.readthedocs.build/

…ocumentation (pythonGH-118597)

Add thread-safety clarifications to the SSLContext documentation. Per the issue:

This issue has also come up [here](psf/requests#6667) where the matter was clarified by @tiran in [this comment](psf/requests#6667):
> `SSLContext` is designed to be shared and used for multiple connections. It is thread safe as long as you don't reconfigure it once it is used by a connection. Adding new certs to the internal trust store is fine, but changing ciphers, verification settings, or mTLS certs can lead to surprising behavior. The problem is unrelated to threads and can even occur in a single-threaded program.
(cherry picked from commit 4f59f86)

Co-authored-by: mm-matthias <[email protected]>
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jun 16, 2024
@gpshead gpshead enabled auto-merge (squash) June 16, 2024 20:28
@gpshead gpshead merged commit 7655989 into python:3.13 Jun 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants