GH-108202: Combine documentation of calendar constants
#108492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
added
docs
|
Thanks, shall we also group the day things together, and the month things together?
|
|
Good idea, done. A |
erlend-aasland
approved these changes
Aug 27, 2023
|
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Sorry, @AA-Turner and @hugovk, I could not cleanly backport this to |
AA-Turner
added a commit
to AA-Turner/cpython
that referenced
this pull request
Aug 28, 2023
…ts (pythonGH-108492). (cherry picked from commit 5d936b6) Co-authored-by: Adam Turner <[email protected]>
|
Sorry for the delay, backport now opened. A |
|
GH-108579 is a backport of this pull request to the 3.12 branch. |
Yhg1s
pushed a commit
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The weekday constants were already defined in the "data attributes" section of the docs, this moves the month constants to match. This also benefits the reader of the
calendardocumentation, as the first API documented is nowcalendar.Calendar, rather than two enumerations.📚 Documentation preview 📚: https://cpython-previews--108492.org.readthedocs.build/en/108492/library/calendar.html