fix(test): avoid racy reader vs writer contender in test_rw_lock
#747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See test failure https://github.com/python-zk/kazoo/actions/runs/8116444130/job/22206401448?pr=744
Why is this needed?
test_rw_lock
is creating 2 threads (reader
andwriter
) and, after being started, it is expected thatreader
is a contender beforewriter
. In some busy systems (like the CI... it's always the CI!) this may not be true and lead to the test failure becausewriter
can be a contender beforereader
. This commit makes sure thatreader
is always a contender beforewriter
.Proposed Changes
reader
being a contender before startingwriter
Does this PR introduce any breaking change?
No!