Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update Python and ZK in testing suite #737

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

StephenSorriaux
Copy link
Member

@StephenSorriaux StephenSorriaux commented Jan 23, 2024

Fixes #708

Why is this needed?

Python 3.7 is EOL since last year, Python 3.11 and Python 3.12 are here now.
ZK 3.6 is EOL since end of 2022 and ZK 3.9 is here.

Proposed Changes

  • drop Python 3.7 from testing
  • add Python 3.11 and 3.12 to testing
  • drop ZK 3.4 and 3.5
  • add ZK 3.8 and 3.9

Does this PR introduce any breaking change?

No.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (383cdf8) 96.76% compared to head (1aaabe7) 96.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
- Coverage   96.76%   96.73%   -0.03%     
==========================================
  Files          27       27              
  Lines        3557     3557              
==========================================
- Hits         3442     3441       -1     
- Misses        115      116       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@StephenSorriaux StephenSorriaux changed the title test: remove Python 3.7, add Python 3.11 and Python 3.12 test: update Python and ZK in testing suite Jan 23, 2024
jeffwidman
jeffwidman previously approved these changes Jan 23, 2024
@jeffwidman
Copy link
Member

Thanks 🙏

Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for merging w/o worrying about the decrease in coverage, it's a red herring here IMO.

@StephenSorriaux StephenSorriaux merged commit 1a23100 into master Jan 24, 2024
29 of 30 checks passed
@StephenSorriaux StephenSorriaux deleted the feat/clean-python-versions branch January 24, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta: Minimum supported python version
2 participants