Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crash. Make identifier_to_string less footgunny. #323

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix crash. Make identifier_to_string less footgunny. #323

merged 2 commits into from
Nov 18, 2024

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Nov 18, 2024

fixes #322

@jakkdl jakkdl mentioned this pull request Nov 18, 2024
Open
Zac-HD
Zac-HD approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick patch!

@Zac-HD Zac-HD merged commit 14d9906 into python-trio:main Nov 18, 2024
10 checks passed
@jakkdl jakkdl deleted the visitor91x_crash branch November 18, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zac-HD Zac-HD Zac-HD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New crash since 24.9.5
2 participants
@jakkdl @Zac-HD