-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async101 & async119 now respects transform-async-generator-decorators #316
async101 & async119 now respects transform-async-generator-decorators #316
Conversation
hrm, I kinda wanna make the |
docs/changelog.rst
Outdated
24.11.1 | ||
======= | ||
- :ref:`ASYNC101` and :ref:`ASYNC119` are now silenced for decorators in :ref:`transform-async-generator-decorators` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably remove the changelog from the first of this and #317 to merge, so we do a single release?
wait, I just noticed we have def update_version() -> None:
# If we've added a new version to the changelog, update __version__ to match
last_version = next(iter(get_releases()))
if last_version != VERSION:
INIT_FILE = ROOT_PATH / "flake8_async" / "__init__.py"
subs = (f'__version__ = "{VERSION}"', f'__version__ = "{last_version}"')
INIT_FILE.write_text(INIT_FILE.read_text().replace(*subs)) which means the test for checking changelog matching |
Oh I can't even have |
fixes #315
I noticed the flag wasn't documented at all in
usage.rst
, so added it there.I also think it should be enabled for ASYNC119?
The flag becomes somewhat weirdly named for ASYNC101 since it will also suppress errors in sync functions. Idk if it warrants a rename, or I should just mention it in the docs, or explicitly only make it have an effect on async funcs, or something else.