Add flake8 and mypy to Travis #86
Conversation
Codecov Report
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 98.53% 98.52% -0.02%
==========================================
Files 10 10
Lines 1567 1556 -11
Branches 179 184 +5
==========================================
- Hits 1544 1533 -11
Misses 12 12
Partials 11 11
Continue to review full report at Codecov.
|
|
Waiting on #82 before proceeding. |
|
Should probably also add |
|
@glyph |
|
@glyph: |
| @@ -1112,7 +1112,6 @@ def test_autorooted(self): | |||
|
|
|||
| attempt_unrooted_absolute = URL(host="foo", path=['bar'], rooted=False) | |||
| normal_absolute = URL(host="foo", path=["bar"]) | |||
| attempted_rooted_replacement = normal_absolute.replace(rooted=True) | |||
There was a problem hiding this comment.
weird. that's a real bug. we should be asserting something about that object
There was a problem hiding this comment.
I think that asserting something about that object is unrelated to this PR, though, and is an example of why landing this PR would be good :-)
There was a problem hiding this comment.
Not sure how you want to address that. Can you open a PR with a fix or an issue to track it?
There was a problem hiding this comment.
For reference, this came via #91
There was a problem hiding this comment.
Yeah, I guess what I meant was I should have asserted something about that object :).
You can feel free to just clean it up here for the time being, and assign any resulting issue to me
There was a problem hiding this comment.
Issue #99 for replacing this.
…xing mypy errors around unspecified generics.
Travis isn't running
flake8ormypy. That seems a bit silly.