Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code の Python 開発に便利なプラグイン追加のドキュメントを追加 #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

laughk
Copy link
Contributor

@laughk laughk commented Oct 29, 2021

この PR の目的

VS Code の Python 開発に便利なプラグイン追加のドキュメントを追加します。

@laughk laughk self-assigned this Oct 29, 2021
@laughk laughk force-pushed the feature/setup-vscode-plugin-for-python branch from 0bd53e4 to b9f36e1 Compare November 6, 2021 07:48
@laughk laughk marked this pull request as ready for review November 6, 2021 07:51
Copy link
Member

@terapyon terapyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

指摘を2件入れました。
確認をお願いします。

- 主要なフレームワーク向けのデバッグ設定の利用
- コードチェックツールの実行
- テストコード実行
- デバッグや
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「や」が余分?
他のことを追記したかった?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

これは最初1文で書いていたものをリスト化した際の消し忘れですね... 直します。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらで修正しました 0d0523a


拡張機能「Python」と、それに関連する「Jupyter」「Pylance」等の拡張機能も同時に追加されます。

![「Python」が追加出来た状態の拡張機能一覧](images/plugin06.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

画像のリンクが切れている?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

参照している画像ファイル名が間違ってそうでした... 🙈

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらで修正しました 0d0523a

Copy link
Member

@takanory takanory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

- 主要なフレームワーク向けのデバッグ設定の利用
- コードチェックツールの実行
- テストコード実行
- デバッグや
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

- デバッグや
- VS Code 内での Jupyter Notebook の実行

また、拡張機能「Python」を追加すると「[Jupyter](https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter)」「[Pylance](https://marketplace.visualstudio.com/items?itemName=ms-python.vscode-pylance)」という拡張機能も同時に追加されます。これらも「Python」同様に Python のコードを書く際に強力な支援が受けられるようになるものです。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

その2つってなんなの?って思いそうなので、簡単な説明があるとうれしいかな。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

それぞれの説明と、確認したところ Jupyter にはさらに依存で入るプラグインもあったため、それらの説明も入れました。
7ae0792

@terapyon
Copy link
Member

@laughk 指摘が入っているので確認、修正をお願いします。

@laughk laughk force-pushed the feature/setup-vscode-plugin-for-python branch from 50778ee to 7ae0792 Compare November 29, 2021 10:28
@laughk laughk requested review from terapyon and takanory November 29, 2021 10:30
@laughk
Copy link
Contributor Author

laughk commented Nov 29, 2021

@terapyon @takanory

確認、対応が遅くなりまして申し訳ないです。
いただいたコメントをもとに修正しいましたのでご確認をお願いします 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants