Enable 3.13's colorized output (snekbox half) #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenanigansd
approved these changes
Nov 14, 2024
MarkKoz
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the snekbox side of changes made to allow bot's
!evalto support colored output. The first of the two commits for bot's side allows ANSI codes to be rendered when given viaprintor such, but Python 3.13 does not produce these colors in tracebacks without an environment variable. Per documentation, there are two such envars -PYTHON_COLORSandFORCE_COLOR. Testing has shownFORCE_COLORto have no effect in eval output, whilePYTHON_COLORS(even by itself) produces colored tracebacks.The insertion of ANSI codes produces significant problems when code is long enough to require uploading to pinnwand, however, so this PR probably should not be merged unless the
Prevent 3.13's ANSI escapes from mangling pinnwand uploadscommit from bot's PR is also merged, which fixes the problems.python-discord/bot#3198 is bot's half