Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor file structure and nsjail module #194

Merged
merged 7 commits into from
Nov 5, 2023
Merged

Refactor file structure and nsjail module #194

merged 7 commits into from
Nov 5, 2023

Conversation

MarkKoz
Copy link
Member

@MarkKoz MarkKoz commented Sep 16, 2023

Just a refactor. See commits messages for more info.

@MarkKoz MarkKoz added area: backend Related to internal functionality and utilities area: nsjail Related to NsJail and its configuration labels Sep 16, 2023
@MarkKoz MarkKoz requested review from jb3 and Den4200 as code owners September 16, 2023 20:38
@MarkKoz MarkKoz enabled auto-merge September 16, 2023 20:39
@MarkKoz MarkKoz changed the title Refactor Refactor file structure and nsjail module Sep 16, 2023
@coveralls
Copy link

coveralls commented Sep 16, 2023 •
edited
Loading

Coverage Status

coverage: 91.076% (+0.1%) from 90.96%
when pulling f7407b1 on refactor-2
into 32fa649 on main.

ChrisLovering
ChrisLovering approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@ChrisLovering ChrisLovering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, much clearer layout too!

@MarkKoz
Remove Python 3.13 from image
f7407b1 
It seems to be unstable in terms of whether the build or tests will
succeed.
@MarkKoz MarkKoz merged commit 841b52b into main Nov 5, 2023
6 checks passed
@MarkKoz MarkKoz deleted the refactor-2 branch November 5, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLovering ChrisLovering ChrisLovering approved these changes

@jb3 jb3 Awaiting requested review from jb3 jb3 is a code owner

@Den4200 Den4200 Awaiting requested review from Den4200 Den4200 is a code owner

Assignees
No one assigned
Labels
area: backend Related to internal functionality and utilities area: nsjail Related to NsJail and its configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkKoz @coveralls @ChrisLovering