Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for compatibility with newer OpenWrt versions. #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fail-Safe
Copy link

Update 1:
The ifname property of a network appears to be hit or miss. The device property is consistent now in uci network output.

Update 2:
On OpenWrt SNAPSHOT r24673-659f027e69, this service failed to start due to the following error:

Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]: flag provided but not defined: -if-wan eth0
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]: Usage of /usr/bin/goeap_proxy:
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:   -if-router string
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:     	interface of the AT&T Router
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:   -if-wan string
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:     	interface of the AT&T ONT/WAN
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:   -ignore-logoff
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:     	ignore EAPOL-Logoff packets
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:   -promiscuous
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:     	place interfaces into promiscuous mode instead of multicast
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:   -version
Mon Dec 18 11:18:39 2023 daemon.err goeap_proxy[2017]:     	display version

Appending the explicit -if-wan and -if-router args to the procd command corrects the above error.

@feiyax
Copy link

feiyax commented Jun 9, 2024

While the ifname -> device part makes sense, I don't think the -if-wan and -if-router is expected.

The change in goeap_proxy's usage was intentional, according to the commit bbbb4292fc105da01dc5d13c386d7f6981700cca in the author's goeap_proxy repo.

What is missing though, is that this openwrt-feeds repo is still pointing to the rev 0.2.0 of the goeap_proxy source, making a mismatch between the goeap_proxy's input format and this repo's shell script's calling arguments.

Something like this would do:

diff --git a/net/goeap_proxy/Makefile b/net/goeap_proxy/Makefile
index 5bfe330..605b867 100644
--- a/net/goeap_proxy/Makefile
+++ b/net/goeap_proxy/Makefile
@@ -1,11 +1,11 @@
 include $(TOPDIR)/rules.mk

 PKG_NAME:=goeap_proxy
-PKG_VERSION:=0.2.0
+PKG_VERSION:=0.3.0
 PKG_RELEASE:=1
 PKG_SOURCE_PROTO:=git
 PKG_SOURCE_URL:=https://github.com/pyther/goeap_proxy.git
-PKG_SOURCE_VERSION:=12ebcc82b92fd69083e5b3ffde9050e93a20d17a
+PKG_SOURCE_VERSION:=3abd66cf35c70b86fe75989ca64c7a72cc8fa797

 PKG_BUILD_DEPENDS:=golang/host
 PKG_BUILD_PARALLEL:=1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants