Adding delay slider to QR and other small changes

[tadeubas]

• Added a delay slider to change the QR code frames velocity.
• Changed some labels
• Changed layout a bit
• Simplified display_QR thread logic
• Now some options are disabled when selecting no_split or when clicking to generate QR

[pythcoiner]

Thx for the PR, i'll try to review in the week!

[tadeubas]

thx for the suggestions!

[tadeubas]

Change on line 610 broke the code:

if self.display_qr:

error:

seedqreader.py", line 610, in on_delay_slider_move
    if self.display_qr:
       ^^^^^^^^^^^^^^^
AttributeError: 'MainWindow' object has no attribute 'display_qr'

[tadeubas]

reverted the first change in line 380 as it made the change in delay to stop working while QR is visible:

self.delay=delay

[tadeubas]

Here is the full quote from his book The Art of Computer Programming: “The real problem is that programmers have spent far too much time worrying about efficiency in the wrong places and at the wrong times; premature optimization is the root of all evil (or at least most of it) in programming.”

[pythcoiner]

@tadeubas do you plan more changes or i can review one more time?

[tadeubas]

I will only check one issue with animated ur qr not showing the frames after some time

[tadeubas]

I think it's working fine now, I didn't see the QR frozen on the screen anymore (sometimes when waiting too long, the user needed to interact with the app to "unfreeze" the QR animation).

I'm done

[tadeubas]

The code is not pretty or optimized, but it is 100% functional and I think "bug free". Please test the features, don't focus too much on the code, it doesn't need to be optimized and/or pretty, but it needs to work correctly. The code runs easily on any personal computer 😉