Bump required pytest version to 4.6 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have started getting an error with pytest>=4,<4.6 when setuptools>=71 (or typeguard>=4.2) is also installed, due to a conflict with older pytest and setuptools' vendored version of typeguard. Out of various ways to resolve this conflict, this is the only one that doesn't involve putting an upper bound on the version of some package. It should still be technically possible to use older versions of pytest along with setuptools<71, if someone really needs to do that, but there isn't any way to express that dependency constraint, and I'm not going to go to any trouble to support long-obsolete versions of packages.
|
P.S. I'll make a separate PR after this one to support pytest 8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have started getting an error with
pytest>=4,<4.6whensetuptools>=71(ortypeguard>=4.2) is also installed, due to a conflict with olderpytestandsetuptools' vendored version oftypeguard. Out of various ways to resolve this conflict, this is the only one that doesn't involve putting an upper bound on the version of some package.It should still be technically possible to use older versions of
pytestalong withsetuptools<71, if someone really needs to do that, but there isn't any way to express that dependency constraint, and I'm not going to go to any trouble to support long-obsolete versions of packages.Testing notes
typeguard<4.2to the test requirements intox.ini, then I run into Failure under pytest-6.2.5 agronholm/typeguard#343setuptools<71then everything works (since it doesn't require any version oftypeguardat all)pytest>=6.2, then again everything workspytest>=4.6and still everything works; it looks like there was a change to how and when plugins are loaded in 4.6 that affects thisHence I'm bumping to 4.6 in this PR.
Closes #97