Add surfaceArea to node parameters #118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm excited about coupling with 2D surface models. These changes are potentially more fundamental to the engine than the other toolkit api development work to date. I propose we create a separate branch for @lrntc to pursue this work. @bemcdonnell sound good? |
|
@michaeltryby, I’ll do this on Monday. Good idea.
|
|
@lrntct, i added a new branch for this work called |
|
@lrntct, is this PR still active? or are its contents part of the coupling PR? |
|
@bemcdonnell The content of this PR is included in the coupling PR. |
|
@lrntct, since this PR is encompassed in the coupling PR, do you mind if we close this one? |
|
@bemcdonnell I believe it is fine to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add surfaceArea to TNode struct.
node_getSurfArea() returns that value by default.
Update toolkitAPI to get and set surfaceArea, and update fullVolume when updating surfaceArea.
See issue #112.