Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for mpvKt player #1470

Closed
wants to merge 3 commits into from

Conversation

talpinum
Copy link

@talpinum talpinum commented Jan 3, 2025

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Added support for the mpvKt player on Android. I didn't check syncplay because I've never used it and don't even know how it works lol (granted, there's no reason why anything'd break).

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@talpinum talpinum changed the title Added support for mpvKt player feat: Added support for mpvKt player Jan 4, 2025
@port19x
Copy link
Collaborator

port19x commented Jan 8, 2025

I don't think syncplay ever worked on android to begin with, you're in the clear with that one

@port19x
Copy link
Collaborator

port19x commented Jan 8, 2025

But just adding a random player is weird, I'd rather not

@port19x port19x closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants