Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove nix-shell section from contributing.md #1453

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Zaechus
Copy link
Contributor

@Zaechus Zaechus commented Nov 11, 2024

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

The shell.nix file was removed in f2e8112 but the current CONTRIBUTING.md file still documents it. This commit removes the entire "Development with nix" section.

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@Zaechus Zaechus requested a review from port19x as a code owner November 11, 2024 06:55
@port19x
Copy link
Collaborator

port19x commented Nov 11, 2024

nice catch!

@port19x port19x changed the title remove nix-shell section from CONTRIBUTING.md docs: remove nix-shell section from contributing.md Nov 11, 2024
@port19x port19x merged commit 0c0bf5b into pystardust:master Nov 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants