-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JWT expiration check #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Scurrra, thanks for pointing it out. I suggest changing the UTC
alias with timezone.utc
as it is not available in all versions of the datetime
package.
@Scurrra, you requested me a review, but I requested a few changes before merging (you shouldn't click "Resolve", you should do "Commit suggestion"). I will wait for your update. Also, I didn't get what was wrong with the old |
My bad, sorry. datetime.utcnow() will be deprecated. |
Co-authored-by: Artyom Vancyan <[email protected]>
Co-authored-by: Artyom Vancyan <[email protected]>
Co-authored-by: Artyom Vancyan <[email protected]>
It was a missdeployment issue, I have fixed it. Thanks for letting me know. Also, it could not be your fault, as these changes haven't been released yet :) |
Motivation:
Doing a project I found this library for easy oauth. Because of lack of experience in the field I decided to learn how the library works. I had a big question on how jwts work, especially in this library. While doing this I found out that there is no check if the token is expired. I added this check to OAuth2Backend.authenticate. I also fixed deprecated datetime.utcnow() function.
All Submissions:
Changes to Core Features: