Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#770 -- doctests after full tests #771

Merged
merged 12 commits into from
Jun 21, 2024
Merged

#770 -- doctests after full tests #771

merged 12 commits into from
Jun 21, 2024

Conversation

jGaboardi
Copy link
Member

This PR resolves #770 .

@jGaboardi jGaboardi added the ci label Jun 20, 2024
@jGaboardi jGaboardi self-assigned this Jun 20, 2024
@jGaboardi jGaboardi requested a review from martinfleis June 20, 2024 20:55
@jGaboardi jGaboardi requested a review from gegen07 June 20, 2024 21:33
gegen07
gegen07 approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@gegen07 gegen07 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have separate jobs and not different actions, right?

@jGaboardi
Copy link
Member Author

Here we have separate jobs and not different actions, right?

It's actually merely extra stage (that doesn't run for the -oldest environment). The full testing suite is run (without doctests) then only doctests are run in the next stage.

@jGaboardi jGaboardi merged commit 7678abf into pysal:main Jun 21, 2024
8 checks passed
@jGaboardi jGaboardi deleted the GH770_doctests_after_full_tests branch June 21, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gegen07 gegen07 gegen07 approved these changes

@martinfleis martinfleis Awaiting requested review from martinfleis

Assignees

@jGaboardi jGaboardi

Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doctests as separate action or workflow
2 participants
@jGaboardi @gegen07