Merge pull request #93 from sjsrey/b16

Fix inconsistency in efficient gini
pysal · Jan 16, 2025 · 0660ce1 · 0660ce1
2 parents 9655a59 + 5c6ea81
commit 0660ce1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/inequality/gini.py b/inequality/gini.py
@@ -32,13 +32,15 @@ def _gini(x):
     http://www.statsdirect.com/help/default.htm#nonparametric_methods/gini.htm.
 
     """
+
     n = len(x)
     try:
         x_sum = x.sum()
     except AttributeError:
         x = numpy.asarray(x)
         x_sum = x.sum()
     n_x_sum = n * x_sum
+    x = x.ravel()  # ensure shape is (n,)
     r_x = (2.0 * numpy.arange(1, len(x) + 1) * x[numpy.argsort(x)]).sum()
     return (r_x - n_x_sum - x_sum) / n_x_sum
 

diff --git a/inequality/tests/test_theil.py b/inequality/tests/test_theil.py
@@ -47,6 +47,7 @@ def test___init__(self):
                 ]
             ),
         )
+
         y = numpy.array([0, 0, 0, 10, 10, 10])
         regions = numpy.array([0, 0, 0, 1, 1, 1])
         theil_d = TheilD(y, regions)
-Original file line number
+Diff line change
@@ Expand Up / @@ -47,6 +47,7 @@ def test___init__(self): @@
                     ]
                 ),
             )
             y = numpy.array([0, 0, 0, 10, 10, 10])
             regions = numpy.array([0, 0, 0, 1, 1, 1])
             theil_d = TheilD(y, regions)
@@ Expand Down @@