Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the Setup GUI #1879

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Updates to the Setup GUI #1879

wants to merge 17 commits into from

Conversation

badpandabear
Copy link
Collaborator

Bug fixes and updates to the Setup GUI, including:

Resizeable metadata/setup/parameters sections when viewing a .pypeit file.
Resizeable metadata columns.
The order of sections within the GUI has been changed to match the order in a .pypeit file.
It's now possible to select which detector to view when viewing raw data.
A help button that links to ReadTheDocs.
The pypeit_setup_gui script has been removed based on discussions in slack.
The mouse cursor changes when over editable items in the metadata.
Bug fixes to sizing of GUI components on MacOS.
The PypeIt logo should now appear as the window icon on MacOS.

@badpandabear
Copy link
Collaborator Author

dev-suite results:

Test Summary
--------------------------------------------------------
--- PYTEST PYPEIT UNIT TESTS PASSED  257 passed, 6569 warnings in 582.33s (0:09:42) ---
--- PYTEST UNIT TESTS PASSED  152 passed, 2669 warnings in 1054.46s (0:17:34) ---
--- PYTEST VET TESTS FAILED  1 failed, 62 passed, 106345 warnings in 2606.40s (0:43:26) ---
--- PYPEIT DEVELOPMENT SUITE PASSED 248/248 TESTS  ---

The one failure was a pre-existing failure in test_datacube.py.

Copy link
Collaborator

@debora-pe debora-pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @badpandabear . I tested a bit this and all looks good. Thank you.
Some of the unit tests in the Dev-Suite still fails for me, but I guess they are still related to a problem of my machine to deal with QT.

@kbwestfall kbwestfall self-requested a review December 16, 2024 18:03
Copy link
Collaborator

@kbwestfall kbwestfall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I tested it a bit on my Mac laptop. Something I noticed that I really liked is that I created a new configuration and copied some files into it from the ObsLog and the GUI automatically filled in the setup and directory blocks. Very nifty!

And, just to confirm my post on Slack, the dev-suite unit tests pass on my machine. So I suggest we keep them all.

@@ -5,6 +5,7 @@
.. include:: ../include/links.rst
"""
import argparse
from datetime import datetime, timezone
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't used, right?



class SetupGUIController(QObject):
"""Controller for the PypeIt setup gui. It is responsible for initializing the GUI,
and performing actions requested by the user.

Args:
args (:class:`argparse.Namespace`): The non-QT command line arguments used to start the GUI.
logfile ()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this?

fixed_font.setPointSize(12)
# msgs.info("Available font families:")
# for family in QFontDatabase.families():
# msgs.info(family)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

def _helpButton(self):
"""Signal handler that responds to the help button being pressed."""

result = QDesktopServices.openUrl(QUrl("https://pypeit.readthedocs.io/en/latest/"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this instead point to https://pypeit.readthedocs.io/en/stable/setup.html? It would also be good to add some GUI-specific instructions there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants