v5 devel branch #307
Draft
v5 devel branch #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This backports (and slightly improves) the new bookmark API from devel_new. Test suite TBD.
Note the following test script:
```
import io
import sys
import logging
import contextlib
logger = logging.getLogger("testLogger")
logger.setLevel(logging.DEBUG)
buf = io.StringIO()
logger.addHandler(logging.StreamHandler(buf)) # !
with contextlib.redirect_stdout(buf), contextlib.redirect_stderr(buf):
print("print to stdout")
print("print to stderr", file=sys.stderr)
logger.info("info message")
logger.warning("warning message")
print(f"{buf.getvalue()!r}")
```
Like this, we get:
> 'print to stdout\nprint to stderr\ninfo message\nwarning message\n'
Without handler:
> 'print to stdout\nprint to stderr\nwarning message\n'
With default handler:
> info message
> warning message
> 'print to stdout\nprint to stderr\n'
Weird.
mara004
force-pushed
the
devel_new
branch
2 times, most recently
from
e18a049 to
94342f8
Compare
Removed PdfDocument.render() & PdfBitmapInfo. Implemented context manager support for PdfDocument. Test suite integration TBD.
mara004
force-pushed
the
devel_new
branch
10 times, most recently
from
2d1c805 to
8049d8e
Compare
Use bool() rather than checking against None. See findings in get_toc(): "We need bool(ptr) here to handle cases where .contents is a null pointer (raises exception on access). Don't use ptr != None, it's always true."
This is longer, but cleaner. Imagine you have to edit it and assignment order gets wrong :P BTW, normalize PdfFormEnv constructor param order.
not tested yet
This comment was marked as outdated.
This comment was marked as outdated.
I'm not sure the memory is reliably being zeroed.
probably not worth it, the caller should handle this. mentioning in the docs should be enough.
to align with .get_bitmap(render=True, scale=True) debug logging
scale (bool) and scale (float) collided
mara004
force-pushed
the
devel_new
branch
2 times, most recently
from
55d4048 to
2675c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.