Start using assignment expressions (:= aka walrus operator) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dependencies.py: - In a comment, rename "imported modules" to "linked modules" - Check against "macro" only in one loop, not in both In __main__.py: avoid an odd use of any() where regular `or` does the trick.
mara004
force-pushed
the
pypdfium2
branch
3 times, most recently
from
242cc9b to
467ba81
Compare
|
Note to self: comparison is corrupt due to a force repush of a commit on the pypdfium2 branch. |
mara004
force-pushed
the
pypdfium2
branch
6 times, most recently
from
cf38d94 to
535dded
Compare
mara004
force-pushed
the
pypdfium2
branch
4 times, most recently
from
683aadb to
e7f92bf
Compare
|
There's also ctypesgen/src/ctypesgen/printer_python/printer.py Lines 70 to 71 in c08b0cb where we could cache Path.cwd() locally by assignment expression.
|
mara004
force-pushed
the
pypdfium2
branch
12 times, most recently
from
c12e8d1 to
0f183c9
Compare
mara004
force-pushed
the
pypdfium2
branch
10 times, most recently
from
8590bae to
fd4eeb8
Compare
mara004
force-pushed
the
pypdfium2
branch
2 times, most recently
from
b933c9b to
20d76c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There doesn't seem to be any real need yet, but it might be nice to have and get started with from a code style POV.
Yet, I believe otherwise the codebase itself might still be compatible with versions below 3.7, like maybe >= 3.4 or something, so this might yet be a bit of a concern. I believe opensuse leap still ships 3.6 ...