Type setuptools/msvc.py dir methods and properties #4755
Conversation
| return sdkdir or '' | ||
| return sdkdir | ||
|
|
||
| return None | ||
| return '' |
There was a problem hiding this comment.
This one I'm not entirely certain of, and does change the possible return types.
dir-related properties of this class are a mixed bag on whether they return None or '' as a fallthrough case. And are almost never documented as returning None (which is fixed in this PR).
However all other properties that can return None are checked for truthiness when used, this one isn't. (hence it was causing issues for #4744)
The redundant or '' makes me think this may have been intended to not return None. But the true intention is unclear to me.
After further research, it was auto-added here as an explicit return: https://github.com/pypa/setuptools/pull/4169/files#diff-2f10e0b183f00587feb575c7716d38f4951d4f7ded5b714396e96066ae7254bdR953
Now I'm pretty sure that the original intention was to return a '' by default. But that means maybe other methods as well ?
Anyway, if you think this should return None by default, I'll add checks to the methods that use this property instead.
Avasam
force-pushed
the
type-msvc-dir-methods-and-properties
branch
from
61b15bf
to
5ab8346
Compare
Avasam
force-pushed
the
type-msvc-dir-methods-and-properties
branch
from
5ab8346
to
6ad33ba
Compare
Summary of changes
Extracted from #4744 with additional fixes
Pull Request Checklist
newsfragments/.(See documentation for details)