Implement PEP 643 (Dynamic field for core metadata)
#4698
+471
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abravalheri
force-pushed
the
issue-2685-pep643
branch
2 times, most recently
from
94a60ef
to
2ea79ce
Compare
2 tasks
|
@jaraco would this kind of approach be acceptable in setuptools? |
This was referenced Oct 24, 2024
abravalheri
force-pushed
the
issue-2685-pep643
branch
from
2ea79ce
to
f7b42e4
Compare
…ad of _static.{Tuple,Mapping} for better compatibility
abravalheri
force-pushed
the
issue-2685-pep643
branch
from
f7b42e4
to
38d6b05
Compare
jaraco
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
I haven't gone deep into the details, but at a high level, this change seems to honor the intentions of PEP 643.
It's not obvious to me what changes from a user's perspective. What projects are affected by this change? Does it simplify or complicate their experience? I think the answer is that projects largely don't have to do anything, but this change gives more fidelity to the metadata (at the cost of the added logic maintenance). If that's right, that seems like a fair tradeoff. Happy to give it a try. Let me know if there's a type of project you think I should run it against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: #4701 needs to be merged first, then this PR needs to be rebased (probably there will be conflicts). It might also be a good idea to wait until the next version of wheel is released (v0.45).
Summary of changes
This PR attempts to implement the 2nd approach suggested in #2685:
Values given via
setup.pyare considered dynamic for the sake of simplicity.The "trick" implemented in this PR to avoid the problems with plugins/customisations described in #4629 (comment), is to mark static values instead of dynamic ones.
This marking is a bit "unconventional" (via subclasses of buit-in types), but it simplifies the tracking of changes and is backward compatible with the existing distutils/setuptools code base.
OPEN PROBLEM:
wheel.metadata.pkginfo_to_metadatahardcodesMetadata-Version: 2.1.PKG_INFOfile in setuptools is good enough and obviate usage ofpkginfo_to_metadata=> Preserve originalPKG-INFOcontents when creating wheel (instead of callingwheel.metadata.pkginfo_to_metadata) #4701.Closes #2685
Pull Request Checklist
newsfragments/.(See documentation for details)