-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync latest distutils #4103
Sync latest distutils #4103
Conversation
…als with booleans.
…re-use _newer logic, and avoid complexity in branching."
…he concept of filtering results over a sequence of tuples.
Cherry-picked from a40114a.
…atest Python to succeed.
Update best practices
75ea580
to
c614ef5
Compare
I don't understand why the pull request tests are failing but the push tests are fine... because they are both based on main so the diff between pull request and push should be zero. |
There are some differences in Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the following suggestions would help with the diffcov errors?
n_targets.append(targets[i]) | ||
|
||
return n_sources, n_targets | ||
def __getattr__(name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def __getattr__(name): | |
def __getattr__(name): # pragma: no cover |
|
||
try: | ||
from distutils._modified import newer_pairwise_group | ||
except ImportError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except ImportError: | |
except ImportError: # pragma: no cover |
Oh! Good news. The tests that were failing before stopped failing after I closed and re-opened the PR. Now all that's failing is the diffcov tests. I'm happy to ignore those failures. Thanks for the extra set of eyes! |
Summary of changes
Closes
Pull Request Checklist
newsfragments/
.(See documentation for details)