normalize sdist/wheel artifact file perms #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently hatchling just inherits a 700 on each from tempfile.mkstemp, which isn't particularly friendly to CI/build systems. We apply normalize_file_permissions to set the output artifacts to 644.
named normalize_artifact_permissions().
|
@ofek I believe this is ready for a second pass from you, thanks 👍 |
ofek
requested changes
May 28, 2024
rather than on tempfile creation.
|
@ofek sure, moved. should be good now i think 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1519.
currently hatchling just inherits a 700 on each from tempfile.mkstemp, which isn't particularly friendly to CI/build systems. We apply normalize_file_permissions to set the output artifacts to 644.
wrt tests, I just copypasta'd another one to add a new test explicitly for the perms test; if you'd like i can just remove and tack the logic into one of the existing tests instead (I couldn't find one that seemed specific enough).