fix: don't set macOS less than 11 on ARM #1441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/fix/macos11
branch
from
cffc6f8 to
19d47c3
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/macos11
branch
from
19d47c3 to
7d6cecf
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/macos11
branch
from
7d6cecf to
1b0c6ef
Compare
|
I can't be sure this is correct for Python < 3.9.10. Let's close and just flip the default. #1445 might help / interact too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM never supported macOS <11. I'm not positive this fixes all cases when someone sets
MACOSX_DEPLOYMENT_TARGET<11, I'll have to check later when I'm on ARM.Edit: didn't get the logic right. Let me try this on ARM in a bit then update it here.