fix: infer tag could produce many/musl tags without repair/audit #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/fix/infertag
branch
from
a9bf882 to
0ce8138
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
Co-authored-by: Ofek Lev <[email protected]> 20ca873
stefanor
added a commit
to stefanor/hatch-mypyc
that referenced
this pull request
Jun 27, 2024
pypa/hatch#1438 changed the default tag selection in hatchling: > Linux tag is after many/musl; packaging tools are required to skip > many/musl, see pypa/packaging#160
stefanor
added a commit
to stefanor/hatch-mypyc
that referenced
this pull request
Jun 28, 2024
pypa/hatch#1438 changed the default tag selection in hatchling: > Linux tag is after many/musl; packaging tools are required to skip > many/musl, see pypa/packaging#160
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See pypa/packaging#160 - packaging tools cannot just pick the first tag form the list, they must filter manylinux (and now musllinux) from the list. This sadly was never fixed, as they were going to add a new "local" tag instead that would work on macOS and Windows too, but it never was finished.