Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add life cycle messaging methods to the environment interface #1178

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Conversation

ofek
Copy link
Collaborator

@ofek ofek commented Dec 26, 2023

@juftin Curious your thoughts on this

Copy link
Contributor

Code Coverage

Package Statements
hatch 96.12% (4933 / 5132)
hatchling 97.69% (3775 / 3864)
tests 99.96% (15212 / 15218)
Summary 98.78% (23920 / 24214)

@ofek ofek merged commit f60a90e into master Dec 26, 2023
38 checks passed
@ofek ofek deleted the d branch December 26, 2023 18:04
@juftin
Copy link
Contributor

juftin commented Dec 27, 2023

Very nice, I like this a lot @ofek - sorry for the late reply. I really like seeing this output hatch as the environment is preparing itself. This reminds me that I need to clean up some output on hatch-pip-compile.

@ofek
Copy link
Collaborator Author

ofek commented Dec 27, 2023

Happy to hear! I was thinking it would be nice to allow for custom UI, or no UI in case one needs to have output in the methods themselves like if sync_dependencies had some sort of progress bar output which would depend on what's actually happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants