Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated dependency hash #1169

Merged
merged 4 commits into from
Dec 24, 2023
Merged

fix: updated dependency hash #1169

merged 4 commits into from
Dec 24, 2023

Conversation

juftin
Copy link
Contributor

@juftin juftin commented Dec 20, 2023

resolves #1168

This PR updates dependency_hash on an environment after dependencies_in_sync / sync_dependencies have been called.

@juftin
Copy link
Contributor Author

juftin commented Dec 20, 2023

I ended up resolving this with the following code: https://github.com/juftin/hatch-pip-compile/blob/7def73be215109f9b935adef1e74feef8d342311/hatch_pip_compile/plugin.py#L93-L103

I do think that this is a worthwhile feature to implement though. IMO it's reasonable that sync_dependencies could make changes to the output of dependency_hash so getting the latest hash before updating makes sense to me.

Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ofek ofek merged commit 9aa2c70 into pypa:master Dec 24, 2023
38 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 24, 2023
* fix: updated dependency hash

* adjust tests

* fix

* .

---------

Co-authored-by: Ofek Lev <[email protected]> 9aa2c70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency_hash should be modifiable after sync_dependencies
2 participants