Derotator Offsets #357
Merged
Derotator Offsets #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er and a given observation time.
LeonMee
changed the title
thusser
reviewed
Apr 12, 2024
| @@ -308,5 +310,12 @@ async def _update_celestial_headers(self) -> None: | |||
| "SUNDIST": (None if sun_dist is None else float(sun_dist.degree), "Solar Distance from Target"), | |||
| } | |||
|
|
|||
| def _get_derotator_offset_from_header(self, hdr, obstime): | |||
There was a problem hiding this comment.
Can we rename this to _calculate_derotator_position_from_header?
There was a problem hiding this comment.
Or better: _calculate_derotator_position and don't use the header. The telescope itself knows best, where it's pointing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function that calculates the derotator offset based on a head…er and a given observation time.