v1.12.5 #347
Merged
v1.12.5 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed LocalComm "sender" kwargs
* Added basic unit tests for photutil photometry * Refactored photutil photomertry * Extracted static functions from photutils photometry into its own class * Added additional testcases for better coverage * Added unit tests to sep photometry * Improved sep photometry tests to verify mask behavior * Refactored sep photometry * Fixed background catalog entry when the pixel scale is missing * Adapted handling of missing data between the photometry modules * Adapted run_in_executor calls between photometry modules * Extracted duplicate code from photometry methods to own class * Added tests to aperture photometry * Fixed reference check in aperture photometry test * Removed redundant photometry tests * Pulled getting the position from the catalog into the photometry calculators * Changed to safe getter * Fixed some typing errors
* Added tests for weather module * Added unit tests to update weather * Extracted api calls to weather api class * Removed ambiguity from the weather status * Cleaned up update exception * Fixed unit tests * Refactored fits header before for weather module * Added test for good weather eta * Added missing unit tests * Added tests to weather state
* Added some basic tests to ProjectedOffsets * Added missing unit tests * Removed dead code from projected offsets * Fixed method order of projected offsets * Removed integration test * Fixed intialised check * Added missing test for reset * Refactored function and variable names
* Added some tests to nstar offsets * Added missing basic unit tests to nstar offsets * Removed unnecessary code * Seperated theausssian fit from nstar oss * Fixed docstrings * Fixed default fit result on fit failure * Removed duplication in tests * Added box generator to seperate initial box definition from nstar class * Simplified remove bad sources * Added some clarifications to box generator * Integrated box generator with nstar * Refactored nstar offset calculation * Added missing testcase and None handling * Changed nstars max offset to pixels instead of arc seconds * Seperated the source filtering in box generator into a seperate image processor * Added box overlapping check to box generator * Simplified overlap checking in box generator * Changed background filter calculation to weber contrast * Added docstring to image source filter * Added comment to nstar docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
version 1.12.5