Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix random variables with missing values in pymc deterministics #122

Merged
merged 1 commit into from
Jun 6, 2024
Merged

fix: Fix random variables with missing values in pymc deterministics #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/nutpie/compile_pymc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ def compile_pymc_model(model: "pm.Model", **kwargs) -> CompiledPyMCModel:
raise ValueError(f"Shared variables must have unique names: {val.name}")
shared_data[val.name] = val.get_value().copy()
shared_vars[val.name] = val
seen.add(val)

for val in shared_data.values():
val.flags.writeable = False
Expand Down
3 changes: 2 additions & 1 deletion tests/test_pymc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ def test_pymc_model_shared():
def test_missing():
with pm.Model(coords={"obs": range(4)}) as model:
mu = pm.Normal("mu")
pm.Normal("y", mu, observed=[0, -1, 1, np.nan], dims="obs")
y = pm.Normal("y", mu, observed=[0, -1, 1, np.nan], dims="obs")
pm.Deterministic("y2", 2 * y, dims="obs")

compiled = nutpie.compile_pymc_model(model)
tr = nutpie.sample(compiled, chains=1, seed=1)
Expand Down