Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update all APIs to pyhf v0.7.0 #34

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 3, 2023

Resolves #33

Amends PR #29

* Update all APIs to be consistent with v0.7.0.
   - Remove comment about making measurement on the fly with
     `workspace.get_measurement` as no longer relevant.
   - Remove all use of `workspace.parameters`, now
     `workspace.model().config.parameters`, as the notebooks
      are focusing on workspace attributes, not model config
      attributes.
* Amends PR #29

@matthewfeickert matthewfeickert self-assigned this Mar 3, 2023
book/requirements.txt Outdated Show resolved Hide resolved
@matthewfeickert matthewfeickert changed the title fix: Update API to v0.7.0 fix: Update all APIs to pyhf v0.7.0 Mar 3, 2023
@matthewfeickert matthewfeickert force-pushed the fix/get-building branch 3 times, most recently from 26cc2a4 to f7158d4 Compare March 5, 2023 08:26
@matthewfeickert matthewfeickert marked this pull request as ready for review March 5, 2023 08:54
@kratsg
Copy link
Contributor

kratsg commented Mar 5, 2023

I'd just drop the ws.parameters calls -- since the relevant portion of the tutorial is only talking about workspaces, not models.

@matthewfeickert
Copy link
Member Author

I'd just drop the ws.parameters calls -- since the relevant portion of the tutorial is only talking about workspaces, not models.

@kratsg done.

@matthewfeickert
Copy link
Member Author

Merging as have approval from Giordon over Skype.

@matthewfeickert matthewfeickert merged commit 9f90971 into main Mar 6, 2023
@matthewfeickert matthewfeickert deleted the fix/get-building branch March 6, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small bugs in 'SimpleWorkspace.ipynb' and 'Combinations.ipynb'
2 participants