Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor present-method mechanic #642

Merged
merged 5 commits into from
Nov 18, 2024
Merged

Refactor present-method mechanic #642

merged 5 commits into from
Nov 18, 2024

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Nov 14, 2024

This does two things:

  • Implement the changes in our WgpuCanvasContext to match with the new API in Refactor inter-context-canvas api rendercanvas#21
    • This means that wgpu keeps working with rendercanvas (after the above change)
  • Backport the changes in our gui backends.
    • This means that wgpu.gui keeps working, so we can move to rendercanvas gradually.

@almarklein almarklein changed the title Adopt rendercanvas Refactor present-method mechanic Nov 15, 2024
@almarklein almarklein marked this pull request as ready for review November 15, 2024 14:08
@almarklein almarklein requested a review from Korijn as a code owner November 15, 2024 14:08
@almarklein
Copy link
Member Author

I changed the scope of this PR. Before rendercanvas, the context-canvas interaction was an implementation detail. In pygfx/rendercanvas#21 I propose an improved and documented version. This PR implements that.

@almarklein almarklein merged commit 44f4457 into main Nov 18, 2024
20 checks passed
@almarklein almarklein deleted the new_rendercanvas branch November 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants