Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nitpicky changes flagged by PyCharm #613

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

fyellin
Copy link
Contributor

@fyellin fyellin commented Oct 6, 2024

Typos and grammar mistakes found by PyCharm.

With one exception ("name" was used as a loop variable within another loop that also used "name" as a loop variable), there are no changes to code.

I only took those changes that I thought were really typos or bad grammar. PyCharm doesn't know how to use a/an before acronyms, and wants more commas than I do.

@fyellin fyellin marked this pull request as ready for review October 6, 2024 17:38
@fyellin fyellin requested a review from Korijn as a code owner October 6, 2024 17:38
@fyellin
Copy link
Contributor Author

fyellin commented Oct 7, 2024

Reminder that I don't have write access.

@almarklein almarklein merged commit e99702f into pygfx:main Oct 7, 2024
20 checks passed
@fyellin fyellin deleted the Nitpick branch October 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants