Remove _release code that's duplicated 19 times. #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some comments
almarklein
reviewed
Sep 18, 2024
almarklein
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Sorry for this rush of PRs. I had a 14-hour plane flight and couldn't sleep.
😆
Nice use of the mechanism you introduced earlier! I double-checked all the names. I was not even aware that all objects have a (working) release function now (this was not always the case)!
Korijn
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the duplicate _release code to its superclass
Add some comments.
Sorry for this rush of PRs. I had a 14-hour plane flight and couldn't sleep.