Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More binary builds v2 #582

Merged
merged 25 commits into from
Sep 14, 2024
Merged

More binary builds v2 #582

merged 25 commits into from
Sep 14, 2024

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Sep 13, 2024

@almarklein almarklein requested a review from Korijn as a code owner September 13, 2024 10:00
.github/workflows/cd.yml Outdated Show resolved Hide resolved
@almarklein
Copy link
Member Author

almarklein commented Sep 13, 2024

Need to update the rules for the protected branch to get match the new names of the builds. Other than that this is ready.

@almarklein
Copy link
Member Author

BTW, we already build a wheel for win32, but that was probably broken because it included the 64bit lib :)

Korijn
Korijn previously approved these changes Sep 14, 2024
Copy link
Collaborator

@Korijn Korijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work! Shame the windows wheel test won't work. You could capture the filename in a variable, if that's the issue?

filename=$(ls dist/*.whl)
pip install $filename

@almarklein
Copy link
Member Author

That did the trick, thanks!

@Korijn Korijn merged commit 64ede94 into main Sep 14, 2024
23 checks passed
@Korijn Korijn deleted the builds2 branch September 14, 2024 17:34
@almarklein almarklein mentioned this pull request Sep 20, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows aarch64
2 participants