Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overrideable constants #579

Merged
merged 8 commits into from
Sep 18, 2024
Merged

overrideable constants #579

merged 8 commits into from
Sep 18, 2024

Conversation

fyellin
Copy link
Contributor

@fyellin fyellin commented Sep 12, 2024

Implement override constants
Allow entry_point to be elided if there is only one possible entry point.
Create functions for some common code in _api.py.

@fyellin fyellin marked this pull request as ready for review September 17, 2024 14:54
@fyellin fyellin requested a review from Korijn as a code owner September 17, 2024 14:54
Copy link
Member

@almarklein almarklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@almarklein almarklein merged commit 6088dd8 into pygfx:main Sep 18, 2024
23 checks passed
@fyellin fyellin deleted the override_constants branch September 18, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants