Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support turning on wgpu validation flag #441

Closed
wants to merge 1 commit into from
Closed

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Dec 1, 2023

  • Turn on the flag.
  • Make it conditional (maybe en env var?)
  • Figure out what it does 😆
    • I think this turns on the Vulkan validation layers, if you have the Lunar SDK installed.
    • On MacOS with Metal I see no difference in the (debug) logs.
    • ... I'm having trouble running on Vulkan on MacOS.
    • Windows: With the Vulkan Configurator on, the validation layers are active, and it prints (to sys stdout / file 0) that the validation layer is active ... but it also does this without the change in this pr.

gfx-rs/wgpu-native#327

@almarklein almarklein requested a review from Korijn as a code owner December 1, 2023 12:21
@almarklein almarklein marked this pull request as draft December 1, 2023 13:02
@almarklein
Copy link
Member Author

Closing, because I don't fully understand (yet) what it does. And from what I've seen from it, it does not seem to help much for us (at least not in the case that we were struggling with).

@almarklein almarklein closed this Dec 8, 2023
@almarklein almarklein deleted the validation branch December 8, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant