Address VRAM usage in Shadertoy Utility #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almarklein
reviewed
Nov 14, 2023
Korijn
approved these changes
Nov 14, 2023
almarklein
approved these changes
Nov 14, 2023
|
@Vipitis This looks ready to me. Did you leave it draft for a reason, or can we merge from your end? |
|
@almarklein I considered adding a test to the test_mem folder to try this with like 10k different shaders. But that might take me a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in #405 (but perhaps not really related to that issue), this PR changes a single line to avoid vram build up and eventual crashes.
As I do have a dataset with several thousand Shadertoys, I will see about creating a small script to test this behaviour on different devices.