Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test fixtures to create non-inheritting test DataTree object with duplicated variable, coord, and dim names #9244

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

acrosby
Copy link

@acrosby acrosby commented Jul 13, 2024

The goal of this addition is to provide test capability for HDF5/NetCDF4 dataset with groups that follow ADCIRC model input dataset convention NWS13.

  • Create a pytest fixture to create the test DataTree
  • Test added for opening with open_datatree without errors
  • Other tests?

…d coord names, but different values and sizes, and nothing in the root group to inherit
Copy link

welcome bot commented Jul 13, 2024

Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient.
If you have questions, some answers may be found in our contributing guidelines.

@TomNicholas TomNicholas added the topic-DataTree Related to the implementation of a DataTree class label Jul 23, 2024
@acrosby acrosby marked this pull request as ready for review July 24, 2024 18:48
@acrosby
Copy link
Author

acrosby commented Jul 24, 2024

Let me know if I should rebase or make any other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic-DataTree Related to the implementation of a DataTree class
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants