Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add open_datatree to xarray #8697
add open_datatree to xarray #8697
Changes from 22 commits
0266b63
3899b06
d5b80f9
0c62960
a523d50
1e5e433
e687e4a
4e05d5c
77405d9
81b425f
3c5bcda
9f89256
a4bad61
e4f0374
3b1224c
e447900
352222d
9745864
20d8691
221bc8c
b74764e
6498acc
4280d30
8c54465
afba7ba
aab1744
5b48973
c6bb18a
4d306c0
d386ed3
e291587
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8c54465
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method doesn't exist yet. at that location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you explain why? This should exist, if you use
:py:func:
instead of:py:meth:
(you can usesphobjinv
to find the right role)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it doesn't exist at the top level because we wanted to migrate over the code before allowing a direct import.
Until all of the code was merged, we said it would be imported from xarray.core.datatree. From #8572 First comment
"EDIT: We decided it should return an xarray.DataTree object, or even xarray.core.datatree.DataTree object. So we can start by just copying the basic version in datatree/io.py right now which just calls open_dataset many times."
So I had thought xarray.core.datatree.DataTree made more sense for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the second part of your comment, makes me think I might not understand what you were asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess what I'm asking is:
open_dataset
definitely exists (and it should be possible to link to), so I suppose you meant to writexarray.open_datatree
?Also, once that's fixed, does this cause the docs build to fail? If not I believe it would be fine to leave as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On reflection, I think this should still be
open_dataset
. That is what is in the original docs. And this is describingopen_datatree
, where it's callingopen_dataset
with these**kwargs
each time. So I think this commit should be reverted. As to:py:meth:
vs:py:func:
I don't know and will look at the difference unless you tell me before I figure it out.