-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datatree import (clean) #8688
datatree import (clean) #8688
Conversation
Expose the methods that are explicitly defined in the Dataset class definition
Open datatree
Define all Dataset properties on DataTree
…finition Add API methods in class definition
Expose dataset reduce operations
Add basic CI setup
* black reformatting * add setup.cfg to configure flake8/black/isort/mypy * add setup.cfg to configure flake8/black/isort/mypy xarray-contrib/datatree#22 * passes flake8 * disabled mypy for now Co-authored-by: Joseph Hamman <[email protected]>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0) - [github.com/psf/black: 23.9.1 → 23.10.1](psf/black@23.9.1...23.10.1) - [github.com/keewis/blackdoc: v0.3.8 → v0.3.9](keewis/blackdoc@v0.3.8...v0.3.9) - [github.com/pre-commit/mirrors-mypy: v1.5.1 → v1.6.1](pre-commit/mirrors-mypy@v1.5.1...v1.6.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…atree#275 * change default to_zarr mode to w- * regression test * add whats new entry
* keep attrs in map_over_subtree * more intelligible logic --------- Co-authored-by: Tom Nicholas <[email protected]>
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4 to 5. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix import of xarray.testing internals that was changed by #8404 * bump minimum required version of xarray * linting
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
updates: - [github.com/PyCQA/isort: 5.12.0 → 5.13.2](PyCQA/isort@5.12.0...5.13.2) - [github.com/psf/black: 23.10.1 → 23.12.1](psf/black@23.10.1...23.12.1) - [github.com/pre-commit/mirrors-mypy: v1.6.1 → v1.8.0](pre-commit/mirrors-mypy@v1.6.1...v1.8.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Justus Magin <[email protected]>
…/datatree#285 Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.8.10 to 1.8.11. - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@v1.8.10...v1.8.11) --- updated-dependencies: - dependency-name: pypa/gh-action-pypi-publish dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Justus Magin <[email protected]>
…rray-contrib/datatree#298 * Use napoleon instead of numpydoc, and fixes * docs * A mypy ignore for pre-commit run --all-files * Updated whats-new.rst
typo found while reading the docs
…e#286 * Replace 'lineage' occurences in code by 'parents' * Replace 'lineage' occurences in api.rst by 'parents' * MyPy ignore * whats-new * Re-introduce lineage and deprecate it * Added credit * Added back lineage in api.rst * Update datatree/tests/test_treenode.py Co-authored-by: Tom Nicholas <[email protected]> * Updated lineage and parents, broke tests * Replaced slash by point, tests pass * New PR * Fix tests * Remove iter_parents from api.rst * Avoid entering into the more complex else branch --------- Co-authored-by: Tom Nicholas <[email protected]>
* move from_dict to creation methods * add section for pathlib-like interface * add suggestions for missing pathlib-like api
…array-contrib/datatree#301 * Moves Tree Contents so that simpsons data tree in example is defined. Also changes :py:meth => :py:class since it's a property not a method. * Show result of datatree.match operation for clarity. * fix typo wo => two --------- Co-authored-by: Tom Nicholas <[email protected]>
7c0c819
to
c27f9db
Compare
One tiny comment that I have is to put the PR numbers ( @pydata/xarray, can we temporarily freeze |
c27f9db
to
f4d9d87
Compare
Skips datatree_ CI Adds additional ignore to mypy Adds additional ignore to doctests Excludes xarray/datatree_ from all pre-commmit.ci Adds MINIFEST.in to skip datatree_ packaging
f4d9d87
to
4de10d4
Compare
Woot! Thanks everyone! |
This makes |
This is the exact same steps followed in #8656
But hopefully with a clean history.
I am copying the notes from the previous PR below.
https://github.com/flamingbear/rewritten-datatree is the version of datatree that was m
erged in this PR.
Previous PR notes
This PR imports xarray-contrib/datatree and its history to pydata/xarray/xarray/datatree_
Step one of issue #8572.
This imports the datatree code without exposing
DataTree
as a public API.git filter repo https://github.com/newren/git-filter-repo was used to preserve some history for the merge.
Datatree tags were renamed to
legacy-datatree-{tag}
:Links to xarray-contrib/datatree original PRs are preserved by rewriting the messages using a
replace-message
file.Links to the xarray-contrib/datatree Issues are preserved with a
replace-text
file.The datatree repo was relocated to a subdirectory
and the prepared datatree repository was added as a remote and merged into xarray.
This should allow work to begin on the rest of the steps in #8572